From owner-acpi-jp@jp.freebsd.org  Tue Dec  5 09:02:43 2000
Received: (from daemon@localhost)
	by castle.jp.freebsd.org (8.9.3+3.2W/8.7.3) id JAA59868;
	Tue, 5 Dec 2000 09:02:43 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from kbtfw.kubota.co.jp (firewall-user@kbtfw.kubota.co.jp [133.253.102.202])
	by castle.jp.freebsd.org (8.9.3+3.2W/8.7.3) with ESMTP id JAA59862
	for <acpi-jp@jp.freebsd.org>; Tue, 5 Dec 2000 09:02:42 +0900 (JST)
	(envelope-from haro@tk.kubota.co.jp)
Received: by kbtfw.kubota.co.jp; id JAA12555; Tue, 5 Dec 2000 09:02:37 +0900 (JST)
Received: from unknown(133.253.122.4) by kbtfw.kubota.co.jp via smap (V4.2)
	id xma012468; Tue, 5 Dec 00 09:02:21 +0900
Received: from ktkl129.tk.kubota.co.jp (IDENT:root@kbtgk.eto.kubota.co.jp [133.253.122.3])
	by kbtmk.eto.kubota.co.jp (8.11.1/8.11.1) with ESMTP id eB502Kl76684;
	Tue, 5 Dec 2000 09:02:20 +0900 (JST)
Received: from jkpc15.tk.kubota.co.jp by ktkl129.tk.kubota.co.jp (8.6.13+2.4W/3.4W3-97053016)
	id JAA17284; Tue, 5 Dec 2000 09:00:56 +0900
Received: from localhost (localhost.tk.kubota.co.jp [127.0.0.1])
	by jkpc15.tk.kubota.co.jp (8.11.1/3.7W-02/21/99) with ESMTP id eB500t500919;
	Tue, 5 Dec 2000 09:00:55 +0900 (JST)
To: msmith@freebsd.org
Cc: acpi-jp@jp.freebsd.org
X-Mailer: Mew version 1.94.1 on Emacs 20.7 / Mule 4.0 (HANANOEN)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20001205090055I.haro@tk.kubota.co.jp>
Date: Tue, 05 Dec 2000 09:00:55 +0900
From: Munehiro Matsuda <haro@tk.kubota.co.jp>
X-Dispatcher: imput version 20000228(IM140)
Lines: 42
Reply-To: acpi-jp@jp.freebsd.org
Precedence: list
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+000315
X-Sequence: acpi-jp 937
Subject: [acpi-jp 937] acpi_acad fail to probe/attach
Errors-To: owner-acpi-jp@jp.freebsd.org
Sender: owner-acpi-jp@jp.freebsd.org
X-Originator: haro@tk.kubota.co.jp

Hi Mike,

After the recent import of new ACPICA code, acpi_acad driver has been
failing to probe/attach. 
The changes to acpi.c:acpi_MatchHid() has made acpi_acad_porbe() fail,
because you have dropped the check for (len == 8) case, but the _HID of
AC adopter is "ACPI0003", which is 8 characters long!

Could you backout the related part or apply the included patch?

 Thank you,
  Haro
---8<------8<------8<------8<--- Cut Here ---8<------8<------8<------8<---
--- acpi.c.ctm	Sat Dec  2 05:52:12 2000
+++ acpi.c	Tue Dec  5 08:43:20 2000
@@ -643,14 +643,17 @@
     ACPI_HANDLE		h;
     ACPI_DEVICE_INFO	devinfo;
     ACPI_STATUS		error;
+    int			len;
     
-    if ((hid == NULL) || (strlen(hid) != 7))
+    len = strlen(hid);
+    if ((hid == NULL) || ((len != 7) && (len != 8)))
 	return(FALSE);
     if ((h = acpi_get_handle(dev)) == NULL)
 	return(FALSE);
     if ((error = AcpiGetObjectInfo(h, &devinfo)) != AE_OK)
 	return(FALSE);
-    if ((devinfo.Valid & ACPI_VALID_HID) && !strncmp(hid, devinfo.HardwareId, 7))
+    if ((devinfo.Valid & ACPI_VALID_HID) &&
+        !strncmp(hid, devinfo.HardwareId, len))
 	return(TRUE);
     return(FALSE);
 }
=------------------------------------------------------------------------------
           _ _    Munehiro (haro) Matsuda
 -|- /_\  |_|_|   Business Incubation Dept., Kubota Corp.
 /|\ |_|  |_|_|   1-3 Nihonbashi-Muromachi 3-Chome
                  Chuo-ku Tokyo 103-8310, Japan
                  Tel: +81-3-3245-3318  Fax: +81-3-3245-3315
                  Email: haro@kubota.co.jp
