From owner-acpi-jp@jp.freebsd.org  Tue Dec  5 09:20:01 2000
Received: (from daemon@localhost)
	by castle.jp.freebsd.org (8.9.3+3.2W/8.7.3) id JAA61179;
	Tue, 5 Dec 2000 09:20:01 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from mass.osd.bsdi.com (adsl-63-202-176-64.dsl.snfc21.pacbell.net [63.202.176.64])
	by castle.jp.freebsd.org (8.9.3+3.2W/8.7.3) with ESMTP id JAA61170
	for <acpi-jp@jp.freebsd.org>; Tue, 5 Dec 2000 09:20:00 +0900 (JST)
	(envelope-from msmith@mass.osd.bsdi.com)
Received: from mass.osd.bsdi.com (localhost [127.0.0.1])
	by mass.osd.bsdi.com (8.11.0/8.11.1) with ESMTP id eB50SdF02121;
	Mon, 4 Dec 2000 16:28:40 -0800 (PST)
	(envelope-from msmith@mass.osd.bsdi.com)
Message-Id: <200012050028.eB50SdF02121@mass.osd.bsdi.com>
X-Mailer: exmh version 2.1.1 10/15/1999
To: Munehiro Matsuda <haro@tk.kubota.co.jp>
cc: msmith@freebsd.org, acpi-jp@jp.freebsd.org
In-reply-to: Your message of "Tue, 05 Dec 2000 09:00:55 +0900."
             <20001205090055I.haro@tk.kubota.co.jp> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Mon, 04 Dec 2000 16:28:39 -0800
From: Mike Smith <msmith@freebsd.org>
Reply-To: acpi-jp@jp.freebsd.org
Precedence: list
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+000315
X-Sequence: acpi-jp 938
Subject: [acpi-jp 938] Re: acpi_acad fail to probe/attach 
Errors-To: owner-acpi-jp@jp.freebsd.org
Sender: owner-acpi-jp@jp.freebsd.org
X-Originator: msmith@freebsd.org

> After the recent import of new ACPICA code, acpi_acad driver has been
> failing to probe/attach. 
> The changes to acpi.c:acpi_MatchHid() has made acpi_acad_porbe() fail,
> because you have dropped the check for (len == 8) case, but the _HID of
> AC adopter is "ACPI0003", which is 8 characters long!
> 
> Could you backout the related part or apply the included patch?

Whoops, that was a stupid mistake for me to make.  I think I'm being too
careful with the HID strlen() at all, and I'll just remove it entirely.
Unless a driver passes in a bad HID pointer, it can't hurt.

Thanks for pointing this out; sorry for the inconvenience.

-- 
... every activity meets with opposition, everyone who acts has his
rivals and unfortunately opponents also.  But not because people want
to be opponents, rather because the tasks and relationships force
people to take different points of view.  [Dr. Fritz Todt]
           V I C T O R Y   N O T   V E N G E A N C E


