From owner-acpi-jp@jp.freebsd.org  Fri Dec 15 17:34:38 2000
Received: (from daemon@localhost)
	by castle.jp.freebsd.org (8.9.3+3.2W/8.7.3) id RAA47959;
	Fri, 15 Dec 2000 17:34:38 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from kbtfw.kubota.co.jp (firewall-user@kbtfw.kubota.co.jp [133.253.102.202])
	by castle.jp.freebsd.org (8.9.3+3.2W/8.7.3) with ESMTP id RAA47953
	for <acpi-jp@jp.FreeBSD.org>; Fri, 15 Dec 2000 17:34:37 +0900 (JST)
	(envelope-from haro@tk.kubota.co.jp)
Received: by kbtfw.kubota.co.jp; id RAA17463; Fri, 15 Dec 2000 17:34:34 +0900 (JST)
Received: from unknown(133.253.122.4) by kbtfw.kubota.co.jp via smap (V4.2)
	id xma017398; Fri, 15 Dec 00 17:33:43 +0900
Received: from ktkl129.tk.kubota.co.jp (IDENT:root@kbtgk.eto.kubota.co.jp [133.253.122.3])
	by kbtmk.eto.kubota.co.jp (8.11.1/8.11.1) with ESMTP id eBF8XgJ21716
	for <acpi-jp@jp.FreeBSD.org>; Fri, 15 Dec 2000 17:33:42 +0900 (JST)
Received: from jkpc15.tk.kubota.co.jp by ktkl129.tk.kubota.co.jp (8.6.13+2.4W/3.4W3-97053016)
	id RAA03158; Fri, 15 Dec 2000 17:32:10 +0900
Received: from localhost (localhost.tk.kubota.co.jp [127.0.0.1])
	by jkpc15.tk.kubota.co.jp (8.11.1/3.7W-02/21/99) with ESMTP id eBF8VpR29669
	for <acpi-jp@jp.FreeBSD.org>; Fri, 15 Dec 2000 17:31:51 +0900 (JST)
To: acpi-jp@jp.FreeBSD.org
X-Mailer: Mew version 1.94.1 on Emacs 20.7 / Mule 4.0 (HANANOEN)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20001215173150N.haro@tk.kubota.co.jp>
Date: Fri, 15 Dec 2000 17:31:50 +0900
From: Munehiro Matsuda <haro@tk.kubota.co.jp>
X-Dispatcher: imput version 20000228(IM140)
Lines: 41
Reply-To: acpi-jp@jp.freebsd.org
Precedence: list
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+000315
X-Sequence: acpi-jp 972
Subject: [acpi-jp 972] Compile error with acpi_ec.c
Errors-To: owner-acpi-jp@jp.freebsd.org
Sender: owner-acpi-jp@jp.freebsd.org
X-Originator: haro@tk.kubota.co.jp

Hi all,

I got kernel build error with acpi_ec.c (rev 1.4):

cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -fformat-extensions -ansi -g -nostdinc -I-  -I. -I../.. -I../../dev -I../../../include -I../../contrib/dev/acpica/Subsystem/Include  -D_KERNEL -include opt_global.h -elf  -mpreferred-stack-boundary=2  ../../dev/acpica/acpi_ec.c
../../dev/acpica/acpi_ec.c: In function `EcGpeQueryHandler':
../../dev/acpica/acpi_ec.c:413: warning: unused variable `_ProcName'
../../dev/acpica/acpi_ec.c: In function `EcGpeHandler':
../../dev/acpica/acpi_ec.c:486: `_ProcName' undeclared (first use in this function)
../../dev/acpica/acpi_ec.c:486: (Each undeclared identifier is reported only once
../../dev/acpica/acpi_ec.c:486: for each function it appears in.)
../../dev/acpica/acpi_ec.c: At top level:
../../dev/acpica/acpi_ec.c:211: warning: `acpi_ec_default' defined but not used
*** Error code 1

Included patch seemed to have fixed it.
Could some one commit it?

 Thanks,
  Haro
---8<------8<------8<------8<--- Cut Here ---8<------8<------8<------8<---
--- acpi_ec.c.ctm	Fri Dec 15 17:28:38 2000
+++ acpi_ec.c	Fri Dec 15 17:28:58 2000
@@ -462,6 +462,9 @@
 {
 	struct acpi_ec_softc *sc = Context;
 	int csrvalue;
+
+	FUNCTION_TRACE(__FUNCTION__);
+
 	/* 
 	 * If EC is locked, the intr must process EcRead/Write wait only.
 	 * Query request must be pending.

=------------------------------------------------------------------------------
           _ _    Munehiro (haro) Matsuda
 -|- /_\  |_|_|   Business Incubation Dept., Kubota Corp.
 /|\ |_|  |_|_|   1-3 Nihonbashi-Muromachi 3-Chome
                  Chuo-ku Tokyo 103-8310, Japan
                  Tel: +81-3-3245-3318  Fax: +81-3-3245-3315
                  Email: haro@kubota.co.jp
