From owner-acpi-jp@jp.freebsd.org  Sat Nov 10 01:08:53 2001
Received: (from daemon@localhost)
	by castle.jp.freebsd.org (8.9.3+3.2W/8.7.3) id BAA59898;
	Sat, 10 Nov 2001 01:08:53 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from hermes.fm.intel.com ([192.55.52.18])
	by castle.jp.freebsd.org (8.9.3+3.2W/8.7.3) with ESMTP id BAA59890;
	Sat, 10 Nov 2001 01:08:48 +0900 (JST)
	(envelope-from robert.moore@intel.com)
Received: from petasus.fm.intel.com (petasus.fm.intel.com [10.1.192.37])
	by hermes.fm.intel.com (8.11.6/8.11.6/d: outer.mc,v 1.18 2001/11/06 18:55:09 root Exp $) with ESMTP id fA9G9Fj10830;
	Fri, 9 Nov 2001 16:09:15 GMT
Received: from fmsmsxvs040.fm.intel.com (fmsmsxv040-1.fm.intel.com [132.233.48.108])
	by petasus.fm.intel.com (8.11.6/8.11.6/d: inner.mc,v 1.10 2001/11/06 00:25:50 root Exp $) with SMTP id fA9G98c14756;
	Fri, 9 Nov 2001 16:09:09 GMT
Received: from FMSMSX016.fm.intel.com ([132.233.42.195])
 by fmsmsxvs040.fm.intel.com (NAVGW 2.5.1.6) with SMTP id M2001110908081113066
 ; Fri, 09 Nov 2001 08:08:11 -0800
Received: by fmsmsx016.fm.intel.com with Internet Mail Service (5.5.2653.19)
	id <WQ7F5FDK>; Fri, 9 Nov 2001 08:07:18 -0800
Message-ID: <B9ECACBD6885D5119ADC00508B68C1EA2FE002@orsmsx107.jf.intel.com>
From: "Moore, Robert" <robert.moore@intel.com>
To: "'Mitsuru IWASAKI'" <iwasaki@jp.FreeBSD.org>, acpi-jp@jp.FreeBSD.org
Date: Fri, 9 Nov 2001 08:08:32 -0800 
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2653.19)
Content-Type: text/plain;
	charset="iso-8859-1"
Reply-To: acpi-jp@jp.freebsd.org
Precedence: list
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+010328
X-Sequence: acpi-jp 1465
Subject: [acpi-jp 1465] RE: acpica-unix-20011102 is out
Errors-To: owner-acpi-jp@jp.freebsd.org
Sender: owner-acpi-jp@jp.freebsd.org
X-Originator: robert.moore@intel.com


Yes, this is the correct fix.  The problem was introduced when I flattened
some of the code in this module.  This will appear in the next build.
Thanks,
Bob


-----Original Message-----
From: Mitsuru IWASAKI [mailto:iwasaki@jp.FreeBSD.org]
Sent: Friday, November 09, 2001 5:07 AM
To: acpi-jp@jp.FreeBSD.org
Cc: robert.moore@intel.com
Subject: Re: [acpi-jp 1462] Re: acpica-unix-20011102 is out


> And,
> > 1. Store operation to reference of local variable is broken again.
> > 
> > Method(GBFE,3)
> > {
> >         CreateByteField(Arg0, Arg1, TIDX)
> >         Store(TIDX, Arg2)
> > }
> > Method(BUG1)
> > {
> >         Store(Buffer(0xd) {0x0, 0x18, 0x10, 0x0}, Local2)
> >         Store(1, Local1)
> >         GBFE(Local2, Local1, RefOf(Local3))
> >         if (Local3) {
> >                 Store("OK", DEBUG)
> >         }
> > }
> 
> this problem, I've not get some time to track down, but I got debug traces
> of Store operation from 20011018 and 20011102 version.

I've made the attached patches based on the comparison between debug
traces of both versions, confirmed the problem is solved with the test
case and running 20011102 kernel, so far so good :-)
Bob, I'm not sure whether this is a correct fix, could you verify it?

Thanks

--- dsmthdat.c-	Thu Nov  8 03:59:20 2001
+++ dsmthdat.c	Fri Nov  9 14:55:29 2001
@@ -713,13 +713,13 @@
 
             /* Detach an existing object from the Node */
 
-            AcpiNsDetachObject (Node);
+            AcpiNsDetachObject ((ACPI_NAMESPACE_NODE *)Node->Object);
 
             /*
              * Store this object into the Node
              * (perform the indirect store)
              */
-            Status = AcpiNsAttachObject (Node, ObjDesc,
ObjDesc->Common.Type);
+            Status = AcpiNsAttachObject ((ACPI_NAMESPACE_NODE
*)Node->Object, ObjDesc, ObjDesc->Common.Type);
             return_ACPI_STATUS (Status);
         }
 
