From owner-acpi-jp@jp.freebsd.org  Fri Nov 16 22:20:33 2001
Received: (from daemon@localhost)
	by castle.jp.freebsd.org (8.9.3+3.2W/8.7.3) id WAA85013;
	Fri, 16 Nov 2001 22:20:33 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from tasogare.imasy.or.jp (root@tasogare.imasy.or.jp [202.227.24.5])
	by castle.jp.freebsd.org (8.9.3+3.2W/8.7.3) with ESMTP id WAA85007
	for <acpi-jp@jp.freebsd.org>; Fri, 16 Nov 2001 22:20:32 +0900 (JST)
	(envelope-from iwasaki@jp.FreeBSD.org)
Received: from localhost (iwasaki.imasy.or.jp [202.227.24.92])
	(authenticated as iwa with CRAM-MD5)
	by tasogare.imasy.or.jp (8.11.6+3.4W/8.11.6/tasogare) with ESMTP/inet id fAGDKRW14136;
	Fri, 16 Nov 2001 22:20:27 +0900 (JST)
	(envelope-from iwasaki@jp.FreeBSD.org)
Date: Fri, 16 Nov 2001 22:20:23 +0900 (JST)
Message-Id: <20011116.222023.126569941.iwasaki@jp.FreeBSD.org>
To: andrew.grover@intel.com, robert.moore@intel.com
Cc: acpi-jp@jp.freebsd.org
From: Mitsuru IWASAKI <iwasaki@jp.freebsd.org>
In-Reply-To: <20011116.175012.85417807.iwasaki@jp.FreeBSD.org>
References: <200111160804.fAG84Sk85035@freefall.freebsd.org>
	<20011116.175012.85417807.iwasaki@jp.FreeBSD.org>
X-Mailer: Mew version 2.0 on Emacs 20.7 / Mule 4.0 (HANANOEN)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: acpi-jp@jp.freebsd.org
Precedence: list
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+010328
X-Sequence: acpi-jp 1474
Subject: [acpi-jp 1474] Re: ACPICA 20011109
Errors-To: owner-acpi-jp@jp.freebsd.org
Sender: owner-acpi-jp@jp.freebsd.org
X-Originator: iwasaki@jp.freebsd.org

Hi,

> I've tested my test suite again, found only one problem so far.  It

One more thing.  AccessAs keyword in FieldList is not interpreted correctly.

Method(TES7)
{
        OperationRegion(PIUC, PCI_Config, 0x74, 0x1)
        Field(PIUC, DWordAcc, Lock, Preserve) {
                AccessAs(ByteAcc, 0),
                PIRU,   4
        }

        Store(PIRU, local0)
}

Here, accessing to PIRU should be interpreted as ByteAcc, but it seems
to be still DWordAcc and got the following error...

 exfldio-0201 [20] ExSetupRegion         : Field access width (4 bytes) too large for region size (1)
 exfldio-0212 [20] ExSetupRegion         : Field Base+Offset+Width 0+0+4 exceeds region size (1 bytes) field=0xc160bca8 region=0xc15f9da8
 psxface-0294: *** Error: Method execution failed, AE_AML_REGION_LIMIT


I've made a small patch for this.  Kindly review it.

Thanks

--- dsfield.c-	Fri Nov 16 21:59:26 2001
+++ dsfield.c	Fri Nov 16 22:07:15 2001
@@ -323,7 +323,7 @@
              * entries (until end or another AccessAs keyword)
              * Preserve flag bits other than the ACCESS_TYPE bits
              */
-            Info->FieldFlags  = (UINT8) ((Info->FieldFlags & FIELD_ACCESS_TYPE_MASK) |
+            Info->FieldFlags  = (UINT8) ((Info->FieldFlags & ~(FIELD_ACCESS_TYPE_MASK)) |
                                             ((UINT8) (Arg->Value.Integer >> 8)));
             break;
 
