From owner-acpi-jp@jp.freebsd.org  Sat Nov 17 01:29:35 2001
Received: (from daemon@localhost)
	by castle.jp.freebsd.org (8.9.3+3.2W/8.7.3) id BAA95231;
	Sat, 17 Nov 2001 01:29:35 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from thalia.fm.intel.com (fmfdns02.fm.intel.com [132.233.247.11])
	by castle.jp.freebsd.org (8.9.3+3.2W/8.7.3) with ESMTP id BAA95225;
	Sat, 17 Nov 2001 01:29:34 +0900 (JST)
	(envelope-from robert.moore@intel.com)
Received: from fmsmsxvs043.fm.intel.com (fmsmsxvs043.fm.intel.com [132.233.42.129])
	by thalia.fm.intel.com (8.9.1a+p1/8.9.1/d: relay.m4,v 1.46 2001/10/25 21:02:55 root Exp $) with SMTP id QAA13220;
	Fri, 16 Nov 2001 16:29:31 GMT
Received: from orsmsx26.jf.intel.com ([192.168.65.26])
 by fmsmsxvs043.fm.intel.com (NAVGW 2.5.1.6) with SMTP id M2001111608284511598
 ; Fri, 16 Nov 2001 08:28:45 -0800
Received: by orsmsx26.jf.intel.com with Internet Mail Service (5.5.2653.19)
	id <W0BSJ5BF>; Fri, 16 Nov 2001 08:29:31 -0800
Message-ID: <B9ECACBD6885D5119ADC00508B68C1EA2FE01E@orsmsx107.jf.intel.com>
From: "Moore, Robert" <robert.moore@intel.com>
To: "'Mitsuru IWASAKI'" <iwasaki@jp.FreeBSD.org>,
        "Grover, Andrew"<andrew.grover@intel.com>,
        "Moore, Robert" <robert.moore@intel.com>
Cc: acpi-jp@jp.FreeBSD.org
Date: Fri, 16 Nov 2001 08:29:28 -0800
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2653.19)
Content-Type: text/plain;
	charset="ISO-8859-1"
Reply-To: acpi-jp@jp.freebsd.org
Precedence: list
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+010328
X-Sequence: acpi-jp 1475
Subject: [acpi-jp 1475] RE: ACPICA 20011109
Errors-To: owner-acpi-jp@jp.freebsd.org
Sender: owner-acpi-jp@jp.freebsd.org
X-Originator: robert.moore@intel.com


Thanks, you get the award for finding the most issues in the field support
code!
This fix will appear in the next build.

Bob

-----Original Message-----
From: Mitsuru IWASAKI [mailto:iwasaki@jp.FreeBSD.org]
Sent: Friday, November 16, 2001 5:20 AM
To: andrew.grover@intel.com; robert.moore@intel.com
Cc: acpi-jp@jp.FreeBSD.org
Subject: Re: [acpi-jp 1473] ACPICA 20011109


Hi,

> I've tested my test suite again, found only one problem so far.  It

One more thing.  AccessAs keyword in FieldList is not interpreted correctly.

Method(TES7)
{
        OperationRegion(PIUC, PCI_Config, 0x74, 0x1)
        Field(PIUC, DWordAcc, Lock, Preserve) {
                AccessAs(ByteAcc, 0),
                PIRU,   4
        }

        Store(PIRU, local0)
}

Here, accessing to PIRU should be interpreted as ByteAcc, but it seems
to be still DWordAcc and got the following error...

 exfldio-0201 [20] ExSetupRegion         : Field access width (4 bytes) too
large for region size (1)
 exfldio-0212 [20] ExSetupRegion         : Field Base+Offset+Width 0+0+4
exceeds region size (1 bytes) field=0xc160bca8 region=0xc15f9da8
 psxface-0294: *** Error: Method execution failed, AE_AML_REGION_LIMIT


I've made a small patch for this.  Kindly review it.

Thanks

--- dsfield.c-	Fri Nov 16 21:59:26 2001
+++ dsfield.c	Fri Nov 16 22:07:15 2001
@@ -323,7 +323,7 @@
              * entries (until end or another AccessAs keyword)
              * Preserve flag bits other than the ACCESS_TYPE bits
              */
-            Info->FieldFlags  = (UINT8) ((Info->FieldFlags &
FIELD_ACCESS_TYPE_MASK) |
+            Info->FieldFlags  = (UINT8) ((Info->FieldFlags &
~(FIELD_ACCESS_TYPE_MASK)) |
                                             ((UINT8) (Arg->Value.Integer >>
8)));
             break;
 
