From owner-acpi-jp@jp.freebsd.org  Tue Nov 20 03:42:52 2001
Received: (from daemon@localhost)
	by castle.jp.freebsd.org (8.9.3+3.2W/8.7.3) id DAA43253;
	Tue, 20 Nov 2001 03:42:52 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from thalia.fm.intel.com (fmfdns02.fm.intel.com [132.233.247.11])
	by castle.jp.freebsd.org (8.9.3+3.2W/8.7.3) with ESMTP id DAA43247;
	Tue, 20 Nov 2001 03:42:49 +0900 (JST)
	(envelope-from robert.moore@intel.com)
Received: from fmsmsxvs043.fm.intel.com (fmsmsxvs043.fm.intel.com [132.233.42.129])
	by thalia.fm.intel.com (8.9.1a+p1/8.9.1/d: relay.m4,v 1.46 2001/10/25 21:02:55 root Exp $) with SMTP id SAA16946;
	Mon, 19 Nov 2001 18:42:47 GMT
Received: from fmsmsx28.fm.intel.com ([132.233.42.28])
 by fmsmsxvs043.fm.intel.com (NAVGW 2.5.1.6) with SMTP id M2001111910420120982
 ; Mon, 19 Nov 2001 10:42:01 -0800
Received: by fmsmsx28.fm.intel.com with Internet Mail Service (5.5.2653.19)
	id <W0BQV8H5>; Mon, 19 Nov 2001 10:43:37 -0800
Message-ID: <B9ECACBD6885D5119ADC00508B68C1EA2FE029@orsmsx107.jf.intel.com>
From: "Moore, Robert" <robert.moore@intel.com>
To: "'Mitsuru IWASAKI'" <iwasaki@jp.FreeBSD.org>,
        "Grover, Andrew"<andrew.grover@intel.com>,
        "Moore, Robert" <robert.moore@intel.com>
Cc: acpi-jp@jp.FreeBSD.org
Date: Mon, 19 Nov 2001 10:42:46 -0800
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2653.19)
Content-Type: text/plain;
	charset="iso-8859-1"
Reply-To: acpi-jp@jp.freebsd.org
Precedence: list
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+010328
X-Sequence: acpi-jp 1477
Subject: [acpi-jp 1477] RE: ACPICA 20011109 (was Re: cvs commit: ports/devel/acpicatools 
	Makefile distinfo)
Errors-To: owner-acpi-jp@jp.freebsd.org
Sender: owner-acpi-jp@jp.freebsd.org
X-Originator: robert.moore@intel.com


Yes, this is correct.  I goofed this up, and the fix will appear in the next
label.

Thanks as always,
Bob


-----Original Message-----
From: Mitsuru IWASAKI [mailto:iwasaki@jp.FreeBSD.org]
Sent: Friday, November 16, 2001 12:50 AM
To: andrew.grover@intel.com; robert.moore@intel.com
Cc: acpi-jp@jp.FreeBSD.org
Subject: ACPICA 20011109 (was Re: cvs commit: ports/devel/acpicatools
Makefile distinfo)


Hi, I've found acpica-unix-20011109 last night and updated my ports,
and found a problem in AcpiNsGetAttachedObject().

> iwasaki     2001/11/16 00:04:28 PST
> 
>   Modified files:
>     devel/acpicatools    Makefile distinfo 
>   Log:
>   Update for acpica-unix-20011109.

Some problems which reported in 20011102 have been solved.
Thanks a lot Intel Folks for quick release work!

I've tested my test suite again, found only one problem so far.  It
seems that store operation to reference of local variable is still
broken for another reason i.e.  AcpiNsGetAttachedObject() ignores
ACPI_DESC_TYPE_NAMED object such as local variable.

I attached patch, could you review this as always?

Thanks

--- nsobject.c-	Fri Nov 16 03:57:45 2001
+++ nsobject.c	Fri Nov 16 05:25:56 2001
@@ -363,7 +363,8 @@
     }
 
     if (!Node->Object ||
-        (!(VALID_DESCRIPTOR_TYPE (Node->Object, ACPI_DESC_TYPE_INTERNAL)))
||
+        ((!(VALID_DESCRIPTOR_TYPE (Node->Object, ACPI_DESC_TYPE_INTERNAL)))
&&
+         (!(VALID_DESCRIPTOR_TYPE (Node->Object, ACPI_DESC_TYPE_NAMED))))
||
         (Node->Object->Common.Type == INTERNAL_TYPE_DATA))
     {
         return_PTR (NULL);
