From owner-acpi-jp@jp.FreeBSD.org Mon Dec 17 10:01:01 2001
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6+3.4W/8.11.3) id fBH111n80354;
	Mon, 17 Dec 2001 10:01:01 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from mail11.speakeasy.net (mail11.speakeasy.net [216.254.0.211])
	by castle.jp.FreeBSD.org (8.11.6+3.4W/8.11.3) with ESMTP/inet id fBH110680347
	for <acpi-jp@jp.FreeBSD.org>; Mon, 17 Dec 2001 10:01:00 +0900 (JST)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 9424 invoked from network); 17 Dec 2001 01:00:53 -0000
Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender <jhb@FreeBSD.org>)
          by mail11.speakeasy.net (qmail-ldap-1.03) with SMTP
          for <acpi-jp@jp.FreeBSD.org>; 17 Dec 2001 01:00:53 -0000
Message-ID: <XFMail.011216170044.jhb@FreeBSD.org>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20011216.163221.38718290.iwasaki@jp.FreeBSD.org>
Date: Sun, 16 Dec 2001 17:00:44 -0800 (PST)
From: John Baldwin <jhb@freebsd.org>
To: acpi-jp@jp.FreeBSD.org
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+010331
X-Sequence: acpi-jp 1541
Subject: [acpi-jp 1541] RE: Call for testers: Semaphore and Thread im
Errors-To: owner-acpi-jp@jp.FreeBSD.org
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: jhb@FreeBSD.org


On 16-Dec-01 Mitsuru IWASAKI wrote:
>> > > I think having dedicated thread for interpreter and giving chance to
>> > > execute tasks for other drivers is not so bad idea.
>> > 
>> > You could just implement a private task queue for the interpreter. That'd
>> > be pretty straightforward.
>> 
>> Yeah, I think this is what I wanted to change :-)
>> but it seemed to me that creating kernel thread is easier than
>> private task queue implementation.
> 
> OK, I revised the patches.
> http://people.freebsd.org/~iwasaki/acpi/acpi-mutex-20011216.diff
> 
> The threading is disabled as default unless ACPI_MAX_THREADS is
> specified in the new patches.
> 
> I'll commit this next weekend.

One minor nit that's new: __func__ apparently can't be concatenated with
strings as it is not a constant, but a variable, so you need to use
panic("%s ...", __func__, ...) when the kthread_create() for the taskqueue
thread fails.  Also, why do you call the option ACPI_MAX_THREADS?  Why not
ACPI_TASK_KTHREAD or some such?

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/
