From owner-acpi-jp@jp.FreeBSD.org Mon Dec 17 13:09:19 2001
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6+3.4W/8.11.3) id fBH49JM21071;
	Mon, 17 Dec 2001 13:09:19 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from tasogare.imasy.or.jp (root@tasogare.imasy.or.jp [202.227.24.5])
	by castle.jp.FreeBSD.org (8.11.6+3.4W/8.11.3) with ESMTP/inet id fBH49I621066
	for <acpi-jp@jp.FreeBSD.org>; Mon, 17 Dec 2001 13:09:18 +0900 (JST)
	(envelope-from iwasaki@jp.FreeBSD.org)
Received: from localhost (root@localhost [127.0.0.1])
	(authenticated as iwa with CRAM-MD5)
	by tasogare.imasy.or.jp (8.11.6+3.4W/8.11.6/tasogare) with ESMTP/inet id fBH49CP38766
	for <acpi-jp@jp.FreeBSD.org>; Mon, 17 Dec 2001 13:09:13 +0900 (JST)
	(envelope-from iwasaki@jp.FreeBSD.org)
Date: Mon, 17 Dec 2001 13:08:55 +0900 (JST)
Message-Id: <20011217.130855.59541211.iwasaki@jp.FreeBSD.org>
To: acpi-jp@jp.FreeBSD.org
From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
In-Reply-To: <XFMail.011216170044.jhb@FreeBSD.org>
References: <20011216.163221.38718290.iwasaki@jp.FreeBSD.org>
	<XFMail.011216170044.jhb@FreeBSD.org>
X-Mailer: Mew version 2.0 on Emacs 20.7 / Mule 4.0 (HANANOEN)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+010331
X-Sequence: acpi-jp 1542
Subject: [acpi-jp 1542] Re: Call for testers: Semaphore and Thread im
Errors-To: owner-acpi-jp@jp.FreeBSD.org
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: iwasaki@jp.FreeBSD.org

Thanks John!

> One minor nit that's new: __func__ apparently can't be concatenated with
> strings as it is not a constant, but a variable, so you need to use
> panic("%s ...", __func__, ...) when the kthread_create() for the taskqueue

OK, I'll do so.  Shall I change following line in OsdSchedule.c as well?
    KASSERT(curproc != NULL, (__func__ ": curproc is NULL!"));

> thread fails.  Also, why do you call the option ACPI_MAX_THREADS?  Why not
> ACPI_TASK_KTHREAD or some such?

Because I'd like to reduce the number of options to be newly introduced.
The threading code is enabled only if ACPI_MAX_THREADS is specified and
has value greater than zero.  Also ACPI_MAX_THREADS can indicate the
number of task thread simultaneously.
Having ACPI_TASK_KTHREAD and ACPI_MAX_THREADS looks insistent a bit for me.

Thanks
