From owner-acpi-jp@jp.FreeBSD.org Tue Mar  5 23:09:52 2002
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6+3.4W/8.11.3) id g25E9q810714;
	Tue, 5 Mar 2002 23:09:52 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from tasogare.imasy.or.jp (root@tasogare.imasy.or.jp [202.227.24.5])
	by castle.jp.FreeBSD.org (8.11.6+3.4W/8.11.3) with ESMTP/inet id g25E9pP10709
	for <acpi-jp@jp.FreeBSD.org>; Tue, 5 Mar 2002 23:09:51 +0900 (JST)
	(envelope-from iwasaki@jp.FreeBSD.org)
Received: from localhost (root@tasogare.imasy.or.jp [202.227.24.5])
	by tasogare.imasy.or.jp (8.11.6+3.4W/8.11.6/tasogare) with ESMTP/inet id g25E9hP50894;
	Tue, 5 Mar 2002 23:09:44 +0900 (JST)
	(envelope-from iwasaki@jp.FreeBSD.org)
Date: Tue, 05 Mar 2002 23:09:38 +0900 (JST)
Message-Id: <20020305.230938.41626891.iwasaki@jp.FreeBSD.org>
To: andrew.grover@intel.com, robert.moore@intel.com
Cc: acpi-jp@jp.FreeBSD.org
From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
In-Reply-To: <20020305.213406.95066083.iwasaki@jp.FreeBSD.org>
References: <20020305.213406.95066083.iwasaki@jp.FreeBSD.org>
X-Mailer: Mew version 2.1 on Emacs 20.7 / Mule 4.0 (HANANOEN)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+011218
X-Sequence: acpi-jp 1584
Subject: [acpi-jp 1584] Re: acpica-unix-20020214 GPE bug and patch
Errors-To: owner-acpi-jp@jp.FreeBSD.org
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: iwasaki@jp.FreeBSD.org

> Hi, Intel folks.
> I found a bug related with GPE on acpica-unix-20020214.
> This version's kernel never generates GPEs on some my PCs and
> Fn keys, Lid Open/Close etc. operations were not functional as result.
> 
> Then I've noticed that bitmask for GPE registers are incorrectly set,
> and I've made a simple patch for this bug as follows, so could you
> review it?

Sorry, I've just found that similar fix already made in
http://prdownloads.sourceforge.net/acpi/acpi-20020225-2.5.5.diff.gz
so I'll commit the patch to FreeBSD cvs repo. with the following
modification.

Thanks

> Index: evevent.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/contrib/dev/acpica/evevent.c,v
> retrieving revision 1.1.1.14
> diff -u -r1.1.1.14 evevent.c
> --- evevent.c	23 Feb 2002 05:10:34 -0000	1.1.1.14
> +++ evevent.c	5 Mar 2002 11:10:12 -0000
> @@ -543,7 +543,7 @@
>                  GpeNumber = GpeRegisterInfo->BaseGpeNumber + j;
>                  AcpiGbl_GpeNumberToIndex[GpeNumber].NumberIndex = (UINT8) GpeNumberIndex;
>  
> -                AcpiGbl_GpeNumberInfo[GpeNumberIndex].BitMask = AcpiGbl_DecodeTo8bit[i];
> +                AcpiGbl_GpeNumberInfo[GpeNumberIndex].BitMask = AcpiGbl_DecodeTo8bit[ACPI_MOD_8 (GpeNumber)];

+                AcpiGbl_GpeNumberInfo[GpeNumberIndex].BitMask = AcpiGbl_DecodeTo8bit[j];
