From owner-acpi-jp@jp.FreeBSD.org Thu Mar  7 18:02:31 2002
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6+3.4W/8.11.3) id g2792Vw75040;
	Thu, 7 Mar 2002 18:02:31 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from mass.dis.org (dhcp45-21.dis.org [216.240.45.21])
	by castle.jp.FreeBSD.org (8.11.6+3.4W/8.11.3) with ESMTP/inet id g2792UP75034
	for <acpi-jp@jp.FreeBSD.org>; Thu, 7 Mar 2002 18:02:30 +0900 (JST)
	(envelope-from msmith@mass.dis.org)
Received: from mass.dis.org (localhost [127.0.0.1])
	by mass.dis.org (8.11.6/8.11.6) with ESMTP id g2791va04410;
	Thu, 7 Mar 2002 01:01:58 -0800 (PST)
	(envelope-from msmith@mass.dis.org)
Message-Id: <200203070901.g2791va04410@mass.dis.org>
X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4
To: acpi-jp@jp.FreeBSD.org
cc: andrew.grover@intel.com, robert.moore@intel.com
In-reply-to: Your message of "Tue, 05 Mar 2002 23:09:38 +0900."
             <20020305.230938.41626891.iwasaki@jp.FreeBSD.org> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Thu, 07 Mar 2002 01:01:57 -0800
From: Michael Smith <msmith@freebsd.org>
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+011218
X-Sequence: acpi-jp 1585
Subject: [acpi-jp 1585] Re: acpica-unix-20020214 GPE bug and patch 
Errors-To: owner-acpi-jp@jp.FreeBSD.org
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: msmith@freebsd.org


I plan on trying to merge the 0225 update (which Andy sent me last week) 
fairly soon.  If you have already committed this, don't worry.  If not, 
nag me. 8)

> > Hi, Intel folks.
> > I found a bug related with GPE on acpica-unix-20020214.
> > This version's kernel never generates GPEs on some my PCs and
> > Fn keys, Lid Open/Close etc. operations were not functional as result.
> > 
> > Then I've noticed that bitmask for GPE registers are incorrectly set,
> > and I've made a simple patch for this bug as follows, so could you
> > review it?
> 
> Sorry, I've just found that similar fix already made in
> http://prdownloads.sourceforge.net/acpi/acpi-20020225-2.5.5.diff.gz
> so I'll commit the patch to FreeBSD cvs repo. with the following
> modification.
> 
> Thanks
> 
> > Index: evevent.c
> > ===================================================================
> > RCS file: /home/ncvs/src/sys/contrib/dev/acpica/evevent.c,v
> > retrieving revision 1.1.1.14
> > diff -u -r1.1.1.14 evevent.c
> > --- evevent.c	23 Feb 2002 05:10:34 -0000	1.1.1.14
> > +++ evevent.c	5 Mar 2002 11:10:12 -0000
> > @@ -543,7 +543,7 @@
> >                  GpeNumber = GpeRegisterInfo->BaseGpeNumber + j;
> >                  AcpiGbl_GpeNumberToIndex[GpeNumber].NumberIndex = (UINT8) 
> GpeNumberIndex;
> >  
> > -                AcpiGbl_GpeNumberInfo[GpeNumberIndex].BitMask = AcpiGbl_De
> codeTo8bit[i];
> > +                AcpiGbl_GpeNumberInfo[GpeNumberIndex].BitMask = AcpiGbl_De
> codeTo8bit[ACPI_MOD_8 (GpeNumber)];
> 
> +                AcpiGbl_GpeNumberInfo[GpeNumberIndex].BitMask = AcpiGbl_Deco
> deTo8bit[j];

-- 
To announce that there must be no criticism of the president,
or that we are to stand by the president, right or wrong, is not
only unpatriotic and servile, but is morally treasonable to 
the American public.  - Theodore Roosevelt


