From owner-acpi-jp@jp.FreeBSD.org Sat Jul 13 03:09:31 2002
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6+3.4W/8.11.3) id g6CI9VT26640;
	Sat, 13 Jul 2002 03:09:31 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from mail.speakeasy.net (mail13.speakeasy.net [216.254.0.213])
	by castle.jp.FreeBSD.org (8.11.6+3.4W/8.11.3) with ESMTP/inet id g6CI9Tn26633
	for <acpi-jp@jp.FreeBSD.org>; Sat, 13 Jul 2002 03:09:29 +0900 (JST)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 31775 invoked from network); 12 Jul 2002 18:09:26 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender <jhb@FreeBSD.org>)
          by mail13.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <acpi-jp@jp.FreeBSD.org>; 12 Jul 2002 18:09:26 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g6CI9P036701;
	Fri, 12 Jul 2002 14:09:25 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20020712140924.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.2 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20020713.015803.35656372.iwasaki@jp.FreeBSD.org>
Date: Fri, 12 Jul 2002 14:09:24 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
Cc: andrew.grover@intel.com, acpi-jp@jp.FreeBSD.org
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+020713
X-Sequence: acpi-jp 1676
Subject: [acpi-jp 1676] RE: Intel's acpi
Errors-To: owner-acpi-jp@jp.FreeBSD.org
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: jhb@FreeBSD.org


On 12-Jul-2002 Mitsuru IWASAKI wrote:
> Hi,
> 
>> > From: Mitsuru IWASAKI [mailto:iwasaki@jp.FreeBSD.org] 
>> > I thought the same thing.  Could you integrate attached diffs and
>> > files into your next snapshot?
>> 
>> No, because I don't think arch-specific headers should be included from
>> acenv.h, but rather from the OS-specific header (e.g. freebsd.h).
>> 
>> Yes it's true, we currently do have both WIN32 and WIN64-specific headers
>> included directly, but I'd like to see us consolidate those, I think.
> 
> Ah, I thought ACPI CA is going that way like having WIN32 and
> WIN64-specific headers.
> *BSD systems have the framework for this purpose.  In arch-specific
> header directory, we can have arch-specific headers and arch-independent
> source files can include them, like;
> 
>#include <machine/acpica_machdep.h>
> 
> i.e. in acfreebsd.h includes sys/i386/include/acpica_machdep.h or
> sys/ia64/include/acpica_machdep.h depending on its machine architecture.
> 
> Sample code attached.  Could you review them?

Why use assembly macros for the ACPI global lock.  Why not just use
a kernel mutex?

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/
