From owner-acpi-jp@jp.FreeBSD.org Tue Sep 17 04:02:33 2002
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6+3.4W/8.11.3) id g8GJ2XY99530;
	Tue, 17 Sep 2002 04:02:33 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215])
	by castle.jp.FreeBSD.org (8.11.6+3.4W/8.11.3) with ESMTP/inet id g8GJ2W399520
	for <acpi-jp@jp.FreeBSD.org>; Tue, 17 Sep 2002 04:02:32 +0900 (JST)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 9928 invoked from network); 16 Sep 2002 19:02:28 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender <jhb@FreeBSD.org>)
          by mail15.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <acpi-jp@jp.FreeBSD.org>; 16 Sep 2002 19:02:28 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.5/8.12.5) with ESMTP id g8GJ2RBv054943;
	Mon, 16 Sep 2002 15:02:28 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20020916150207.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.2 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20020914.235034.59647978.iwasaki@jp.FreeBSD.org>
From: John Baldwin <jhb@freebsd.org>
To: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
Cc: acpi-jp@jp.FreeBSD.org
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
Date: Mon, 16 Sep 2002 15:02:07 -0400
X-Sequence: acpi-jp 1828
Subject: [acpi-jp 1828] RE: pci_resume method (Re: acpi issue on my F
Errors-To: owner-acpi-jp@jp.FreeBSD.org
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: jhb@FreeBSD.org
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+020902


On 14-Sep-2002 Mitsuru IWASAKI wrote:
>> > http://people.freebsd.org/~iwasaki/acpi/pci_resume-20020912.diff
>> > Note that John's patch included.  Comments welcome!
>> ># I can remove pci_cfgwrite() from acpi_pci_link_set_irq() again :-)
>> 
>> Cool.  One thing you could do is instead of using the records, just
>> go and re-route interrupts for all children that have a valid
>> intline.  You can get the intpin and bus and stuff from the ivars.
>> You can get the bridge device by doing a device_get_parent() on the
>> bus device.  Then you don't have to maintain your own separate list.
> 
> Ah, yes.  It's easier.  Somethig like this?

Yep.

> And confirmed that both versions redo interrupt routing at resume time.
> I updated whole my patches at:
> http://people.freebsd.org/~iwasaki/acpi/pci_resume-20020914.diff
> 
> Could you merge them into your interrupt routing changes and
> commit them together?

Well, interrupt routing on SMP doesn't work. :-/  Also, interrupt
routing doesn't work on anything but ia64 and i386 right now.  Fixing
all the SMP mess (fixing interrupt routing for the !ACPI case first,
then adding MADT parsing to the i386 MP code as a replacement for
the mptable which will fix the ACPI case of interrupt routing) will
need to happen before we do this.  Also, since this is a change to the
generic PCI code, it might be a good idea to run the idea by the folks
on new-bus@ and probably Warner.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/
