From owner-acpi-jp@jp.FreeBSD.org Thu Apr 17 01:24:57 2003
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) id h3GGOvZ59854;
	Thu, 17 Apr 2003 01:24:57 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from mail.speakeasy.net (mail13.speakeasy.net [216.254.0.213])
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) with ESMTP/inet id h3GGOuY59849
	for <acpi-jp@jp.FreeBSD.org>; Thu, 17 Apr 2003 01:24:56 +0900 (JST)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 31109 invoked from network); 16 Apr 2003 16:23:40 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
          (envelope-sender <jhb@FreeBSD.org>)
          by mail13.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <acpi-jp@jp.FreeBSD.org>; 16 Apr 2003 16:23:40 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h3GGNVOv072654;
	Wed, 16 Apr 2003 12:23:31 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20030416122333.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.4 on FreeBSD
X-Priority: 3 (Normal)
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="_=XFMail.1.5.4.FreeBSD:20030416122150:1321=_"
In-Reply-To: <Pine.BSF.4.44.0304161624270.54843-200000@scrooge.etek.chalmers.se>
From: John Baldwin <jhb@freebsd.org>
To: Magnus B{ckstr|m <b@etek.chalmers.se>, acpi-jp@jp.FreeBSD.org
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
Date: Wed, 16 Apr 2003 12:23:33 -0400
X-Sequence: acpi-jp 2119
Subject: [acpi-jp 2119] RE: [fix] Stack smasher in ACPI.
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: jhb@FreeBSD.org
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+030405

This message is in MIME format
--_=XFMail.1.5.4.FreeBSD:20030416122150:1321=_
Content-Type: text/plain; charset=us-ascii


On 16-Apr-2003 Magnus B{ckstr|m wrote:
> I'm attempting to make -CURRENT work on a compaq evo N800c, and am hitting
> some issues.
> 
> (1) The Intel ACPICA contains a potential memory-corruption bug.
> 
> (2): The N800c AML uses idioms defined in ACPI 2.0 which the FreeBSD
> implementation isn't aware of, and which interacts with (1) so as
> to corrupt the stack and cause a panic.  Specifically, some objects
> report their _CID in the form of a Package with multiple Integers in
> it (ACPI 2.0 specification p.154 section 6.1.2).
> 
> (3): Compaq has defined _HIDs *with* leading asterisks in direct
> violation of ACPI 2.0 p.156 section 6.1.4.  Growl.
> 
> The attached patch is a suggestion for a fix of (1) and the part
> of (2) that interacts with (1).
> 
> I'm working on the rest of (2) and a workaround for (3).
> 
> -- B

The best place to send ACPI patches is the acpi-jp@jp.freebsd.org
mailing list (cc'd).  Hopefully the folks on here can review your
attached patch.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

--_=XFMail.1.5.4.FreeBSD:20030416122150:1321=_
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="acpi_stacksmash.diff"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.BSF.4.44.0304161639020.54843@scrooge.etek.chalmers.se>
Content-Description: ACPI stack smasher fix
Content-Disposition: attachment; filename="acpi_stacksmash.diff"

SW5kZXg6IHNyYy9zeXMvY29udHJpYi9kZXYvYWNwaWNhL3V0YWxsb2MuYw0K
ZGlmZiAtdSBzcmMvc3lzL2NvbnRyaWIvZGV2L2FjcGljYS91dGFsbG9jLmM6
MS4xLjEuMSBzcmMvc3lzL2NvbnRyaWIvZGV2L2FjcGljYS91dGFsbG9jLmM6
MS4xLjEuMS40LjENCi0tLSBzcmMvc3lzL2NvbnRyaWIvZGV2L2FjcGljYS91
dGFsbG9jLmM6MS4xLjEuMQlUdWUgSnVsICA5IDE5OjUxOjMwIDIwMDINCisr
KyBzcmMvc3lzL2NvbnRyaWIvZGV2L2FjcGljYS91dGFsbG9jLmMJV2VkIEFw
ciAxNiAxNjowNjoyMCAyMDAzDQpAQCAtMzg2LDYgKzM4Niw3IEBADQogICAg
ICAgICAvKiBDbGVhciB0aGUgYnVmZmVyICovDQogDQogICAgICAgICBBQ1BJ
X01FTVNFVCAoQnVmZmVyLT5Qb2ludGVyLCAwLCBSZXF1aXJlZExlbmd0aCk7
DQorICAgICAgICBCdWZmZXItPkxlbmd0aCA9IFJlcXVpcmVkTGVuZ3RoOw0K
ICAgICAgICAgYnJlYWs7DQogDQogDQpAQCAtNDAyLDYgKzQwMyw3IEBADQog
ICAgICAgICAvKiBDbGVhciB0aGUgYnVmZmVyICovDQogDQogICAgICAgICBB
Q1BJX01FTVNFVCAoQnVmZmVyLT5Qb2ludGVyLCAwLCBSZXF1aXJlZExlbmd0
aCk7DQorICAgICAgICBCdWZmZXItPkxlbmd0aCA9IFJlcXVpcmVkTGVuZ3Ro
Ow0KICAgICAgICAgYnJlYWs7DQogDQogDQpAQCAtNDEyLDYgKzQxNCw3IEBA
DQogICAgICAgICBpZiAoQnVmZmVyLT5MZW5ndGggPCBSZXF1aXJlZExlbmd0
aCkNCiAgICAgICAgIHsNCiAgICAgICAgICAgICBTdGF0dXMgPSBBRV9CVUZG
RVJfT1ZFUkZMT1c7DQorICAgICAgICAgICAgYnJlYWs7DQogICAgICAgICB9
DQogDQogICAgICAgICAvKiBDbGVhciB0aGUgYnVmZmVyICovDQpAQCAtNDIw
LDcgKzQyMyw2IEBADQogICAgICAgICBicmVhazsNCiAgICAgfQ0KIA0KLSAg
ICBCdWZmZXItPkxlbmd0aCA9IFJlcXVpcmVkTGVuZ3RoOw0KICAgICByZXR1
cm4gKFN0YXR1cyk7DQogfQ0KIA0KSW5kZXg6IHNyYy9zeXMvZGV2L2FjcGlj
YS9hY3BpLmMNCmRpZmYgLXUgc3JjL3N5cy9kZXYvYWNwaWNhL2FjcGkuYzox
LjEuMS42IHNyYy9zeXMvZGV2L2FjcGljYS9hY3BpLmM6MS4xLjEuNi4yLjEN
Ci0tLSBzcmMvc3lzL2Rldi9hY3BpY2EvYWNwaS5jOjEuMS4xLjYJRnJpIE1h
ciAgNyAxNTo0MDo1OSAyMDAzDQorKysgc3JjL3N5cy9kZXYvYWNwaWNhL2Fj
cGkuYwlXZWQgQXByIDE2IDE2OjA2OjIwIDIwMDMNCkBAIC0xMTI5LDE0ICsx
MTI5LDE1IEBADQogICAgICAqIFRoaXMgaXMgYSBoYWNrLg0KICAgICAgKi8N
CiAgICAgaWYgKGVycm9yID09IEFFX0JVRkZFUl9PVkVSRkxPVykgew0KLQlp
ZiAoKGJ1Zi5Qb2ludGVyID0gQWNwaU9zQWxsb2NhdGUoYnVmLkxlbmd0aCkp
ID09IE5VTEwpIHsNCi0JICAgIGVycm9yID0gQUVfTk9fTUVNT1JZOw0KLQl9
IGVsc2Ugew0KLQkgICAgaWYgKEFDUElfU1VDQ0VTUyhlcnJvciA9IEFjcGlF
dmFsdWF0ZU9iamVjdChoYW5kbGUsIHBhdGgsIE5VTEwsICZidWYpKSkgew0K
KwlidWYuUG9pbnRlciA9IE5VTEw7DQorCWJ1Zi5MZW5ndGggPSBBQ1BJX0FM
TE9DQVRFX0JVRkZFUjsNCisNCisJaWYgKEFDUElfU1VDQ0VTUyhlcnJvciA9
IEFjcGlFdmFsdWF0ZU9iamVjdChoYW5kbGUsIHBhdGgsIE5VTEwsICZidWYp
KSkgew0KIAkJZXJyb3IgPSBhY3BpX0NvbnZlcnRCdWZmZXJUb0ludGVnZXIo
JmJ1ZiwgbnVtYmVyKTsNCi0JICAgIH0NCiAJfQ0KLQlBY3BpT3NGcmVlKGJ1
Zi5Qb2ludGVyKTsNCisNCisJaWYgKGJ1Zi5Qb2ludGVyKQ0KKwkgICAgQWNw
aU9zRnJlZShidWYuUG9pbnRlcik7DQogICAgIH0NCiAgICAgcmV0dXJuKGVy
cm9yKTsNCiB9DQo=

--_=XFMail.1.5.4.FreeBSD:20030416122150:1321=_--
End of MIME message
