From owner-acpi-jp@jp.FreeBSD.org Sun Sep  7 09:15:34 2003
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) id h870FYx16694;
	Sun, 7 Sep 2003 09:15:34 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from rootlabs.com (root.org [67.118.192.226])
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) with SMTP/inet id h870FXw16689
	for <acpi-jp@jp.FreeBSD.org>; Sun, 7 Sep 2003 09:15:33 +0900 (JST)
	(envelope-from nate@rootlabs.com)
Received: (qmail 79283 invoked by uid 1000); 7 Sep 2003 00:15:29 -0000
From: Nate Lawson <nate@root.org>
To: Kevin Oberman <oberman@es.net>
cc: acpi-jp@jp.FreeBSD.org
In-Reply-To: <20030906212953.0AB4A5D04@ptavv.es.net>
Message-ID: <20030906171217.B79267@root.org>
References: <20030906212953.0AB4A5D04@ptavv.es.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
Date: Sat, 6 Sep 2003 17:15:29 -0700
X-Sequence: acpi-jp 2655
Subject: [acpi-jp 2655] Re: ACPI related regression and panics 
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: nate@root.org
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+030902

On Sat, 6 Sep 2003, Kevin Oberman wrote:
> > Date: Sat, 6 Sep 2003 11:13:08 -0700 (PDT)
> > From: Nate Lawson <nate@root.org>
> > Please test the patches with ATAng submitted as:
> > Message-ID:  <20030902005646.7f9cc963.eyes@navi.org>
>
> Makes no difference. I still see the same hang on suspend. The system
> prints out the USB failure to reset messages and the ATA resetting
> message, but that's where it ends...with the disk LED on solid.

Sorry to hear that.  Can you try this patch with/without the other patch
to see if it makes a difference:

RCS file: /home/ncvs/src/sys/i386/acpica/acpi_wakeup.c,v
--- acpi_wakeup.c	29 Aug 2003 04:02:19 -0000	1.25
+++ acpi_wakeup.c	7 Sep 2003 00:14:30 -0000
@@ -254,13 +254,13 @@
 			acpi_printcpu();

 		/* Call ACPICA to enter the desired sleep state */
-		ACPI_DISABLE_IRQS();
+		/* ACPI_DISABLE_IRQS(); */
 		ACPI_FLUSH_CPU_CACHE();
 		if (state == ACPI_STATE_S4 && sc->acpi_s4bios)
 			status = AcpiEnterSleepStateS4bios();
 		else
 			status = AcpiEnterSleepState(state);
-		ACPI_ENABLE_IRQS();
+		/* ACPI_ENABLE_IRQS(); */

 		if (status != AE_OK) {
 			device_printf(sc->acpi_dev,

> > As far as S4, please add a hibernation partition and try it out.  I did
> > change the suspend path for hibernation recently and so I'm curious if I
> > need to add new "seatbelts" for the case where no partition exists or if
> > it still works for you with a partition.
>
> I'll try when I get a chance on Monday. Unless you know the partition
> ID values for the hibernation partition on a ThinkPad, I don't
> remember what value to set the slice to.

Everything I've seen says a0 is the partition type to use.  You may also
find this utility useful:
  http://www.procyon.com/~pda/lphdisk/

-Nate
