From owner-acpi-jp@jp.FreeBSD.org Sun Sep  7 14:01:28 2003
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) id h8751St94324;
	Sun, 7 Sep 2003 14:01:28 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from postal2.es.net (postal2.es.net [198.128.3.206])
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) with ESMTP/inet id h8751Rw94319
	for <acpi-jp@jp.FreeBSD.org>; Sun, 7 Sep 2003 14:01:27 +0900 (JST)
	(envelope-from oberman@es.net)
Received: from ptavv.es.net ([198.128.4.29])
        by postal2.es.net (Postal Node 2) with ESMTP (SSL) id MUA74016;
        Sat, 06 Sep 2003 22:01:24 -0700
Received: from ptavv (localhost [127.0.0.1])
	by ptavv.es.net (Tachyon Server) with ESMTP
	id D30885D04; Sat,  6 Sep 2003 22:01:23 -0700 (PDT)
To: Nate Lawson <nate@root.org>
Cc: acpi-jp@jp.FreeBSD.org
In-Reply-To: Message from Nate Lawson <nate@root.org> 
   of "Sat, 06 Sep 2003 17:15:29 PDT." <20030906171217.B79267@root.org> 
From: "Kevin Oberman" <oberman@es.net>
Message-Id: <20030907050123.D30885D04@ptavv.es.net>
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
Date: Sat, 06 Sep 2003 22:01:23 -0700
X-Sequence: acpi-jp 2656
Subject: [acpi-jp 2656] Re: ACPI related regression and panics 
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: oberman@es.net
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+030902

> Date: Sat, 6 Sep 2003 17:15:29 -0700 (PDT)
> From: Nate Lawson <nate@root.org>
> 
> On Sat, 6 Sep 2003, Kevin Oberman wrote:
> > > Date: Sat, 6 Sep 2003 11:13:08 -0700 (PDT)
> > > From: Nate Lawson <nate@root.org>
> > > Please test the patches with ATAng submitted as:
> > > Message-ID:  <20030902005646.7f9cc963.eyes@navi.org>
> >
> > Makes no difference. I still see the same hang on suspend. The system
> > prints out the USB failure to reset messages and the ATA resetting
> > message, but that's where it ends...with the disk LED on solid.
> 
> Sorry to hear that.  Can you try this patch with/without the other patch
> to see if it makes a difference:
> 
> RCS file: /home/ncvs/src/sys/i386/acpica/acpi_wakeup.c,v
> --- acpi_wakeup.c	29 Aug 2003 04:02:19 -0000	1.25
> +++ acpi_wakeup.c	7 Sep 2003 00:14:30 -0000
> @@ -254,13 +254,13 @@
>  			acpi_printcpu();
> 
>  		/* Call ACPICA to enter the desired sleep state */
> -		ACPI_DISABLE_IRQS();
> +		/* ACPI_DISABLE_IRQS(); */
>  		ACPI_FLUSH_CPU_CACHE();
>  		if (state == ACPI_STATE_S4 && sc->acpi_s4bios)
>  			status = AcpiEnterSleepStateS4bios();
>  		else
>  			status = AcpiEnterSleepState(state);
> -		ACPI_ENABLE_IRQS();
> +		/* ACPI_ENABLE_IRQS(); */
> 
>  		if (status != AE_OK) {
>  			device_printf(sc->acpi_dev,
> 
> > > As far as S4, please add a hibernation partition and try it out.  I did
> > > change the suspend path for hibernation recently and so I'm curious if I
> > > need to add new "seatbelts" for the case where no partition exists or if
> > > it still works for you with a partition.
> >
> > I'll try when I get a chance on Monday. Unless you know the partition
> > ID values for the hibernation partition on a ThinkPad, I don't
> > remember what value to set the slice to.
> 
> Everything I've seen says a0 is the partition type to use.  You may also
> find this utility useful:
>   http://www.procyon.com/~pda/lphdisk/

This one did it. Leave the interrupts on and it works fine. It went to
sleep and resumed cleanly.

I will try to get a chance to create a hibernation slice tomorrow and
I'll see how that does.

Thanks again!
-- 
R. Kevin Oberman, Network Engineer
Energy Sciences Network (ESnet)
Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab)
E-mail: oberman@es.net			Phone: +1 510 486-8634
