From owner-acpi-jp@jp.FreeBSD.org Sun Sep 14 06:11:46 2003
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) id h8DLBkI15626;
	Sun, 14 Sep 2003 06:11:46 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from rootlabs.com (root.org [67.118.192.226])
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) with SMTP/inet id h8DLBgw15356
	for <acpi-jp@jp.FreeBSD.org>; Sun, 14 Sep 2003 06:11:45 +0900 (JST)
	(envelope-from nate@rootlabs.com)
Received: (qmail 2751 invoked by uid 1000); 13 Sep 2003 21:11:38 -0000
From: Nate Lawson <nate@root.org>
To: Hiroyuki Aizu <aizu@navi.org>
cc: acpi-jp@jp.FreeBSD.org
In-Reply-To: <20030910225648.3228b607.aizu@navi.org>
Message-ID: <20030913140215.A2632@root.org>
References: <1061343265.951.17.camel@scorpio.eco.imp.mx>
 <20030910225648.3228b607.aizu@navi.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
Date: Sat, 13 Sep 2003 14:11:38 -0700
X-Sequence: acpi-jp 2664
Subject: [acpi-jp 2664] Re: TOSHIBA HCI driver on ACPI.
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: nate@root.org
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+030902

On Wed, 10 Sep 2003, Hiroyuki Aizu wrote:
> I wrote TOSHIBA HCI driver base on ACPI. I was tested on Libretto L5 series.
> This driver should work with other TOSHIBA.
> And this driver works as loadable module.
>
> This driver has a remarkable improvement that you can control with Fn+? keys.

Thank you for posting this.  Although I don't have a Toshiba laptop, I am
willing to import this after some small fixes and testing.

* system_event() should not be an infinite loop (while(1)) but instead:
   while (ACPI_SUCCESS(get_hci_event(..)))
* Extra parentheses for statements like this should be removed:
      if ((error != 0) || (req->newptr == NULL)) {
* Style(9) spacing issues:
      for (i=0; i<HCI_WORDS; i++)

> hw.acpi.toshiba.lcd_brightness_leve: 6

This should end with "level".

-Nate
