From owner-acpi-jp@jp.FreeBSD.org Wed Sep 17 08:16:03 2003
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) id h8GNG3L86616;
	Wed, 17 Sep 2003 08:16:03 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from rootlabs.com (root.org [67.118.192.226])
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) with SMTP/inet id h8GNG2w86518
	for <acpi-jp@jp.FreeBSD.org>; Wed, 17 Sep 2003 08:16:02 +0900 (JST)
	(envelope-from nate@rootlabs.com)
Received: (qmail 10269 invoked by uid 1000); 16 Sep 2003 23:15:58 -0000
From: Nate Lawson <nate@root.org>
To: Hiroyuki Aizu <aizu@navi.org>
cc: acpi-jp@jp.FreeBSD.org
In-Reply-To: <20030914225148.2e1a21f7.aizu@navi.org>
Message-ID: <20030916161328.Q10247@root.org>
References: <1061343265.951.17.camel@scorpio.eco.imp.mx>
 <20030910225648.3228b607.aizu@navi.org> <20030913140215.A2632@root.org>
 <20030914225148.2e1a21f7.aizu@navi.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
Date: Tue, 16 Sep 2003 16:15:58 -0700
X-Sequence: acpi-jp 2671
Subject: [acpi-jp 2671] Re: TOSHIBA HCI driver on ACPI.
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: nate@root.org
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+030902

On Sun, 14 Sep 2003, Hiroyuki Aizu wrote:
> Hi.
>
> I wrote revised version.

One thing I noticed is that you can reduce the code size a lot by
generalizing calls like get/set_hci_cpu_speed.  You can do the arg setup
in a function like:

  call_hci_fn(HCI_SET, HCI_REG_FAN, state << 7, NULL/*output arg*/);

That function could even be merged into call_hci().

-Nate

> On Sat, 13 Sep 2003 14:11:38 -0700
> Nate Lawson <nate@root.org> wrote:
>
> > Thank you for posting this.  Although I don't have a Toshiba laptop, I am
> > willing to import this after some small fixes and testing.
