From owner-acpi-jp@jp.FreeBSD.org Fri Sep 19 02:29:31 2003
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) id h8IHTVj94160;
	Fri, 19 Sep 2003 02:29:31 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from rootlabs.com (root.org [67.118.192.226])
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) with SMTP/inet id h8IHTUJ94154
	for <acpi-jp@jp.FreeBSD.org>; Fri, 19 Sep 2003 02:29:30 +0900 (JST)
	(envelope-from nate@rootlabs.com)
Received: (qmail 15083 invoked by uid 1000); 18 Sep 2003 17:29:25 -0000
From: Nate Lawson <nate@root.org>
To: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
cc: acpi-jp@jp.FreeBSD.org, aizu@navi.org
In-Reply-To: <20030919.013121.43004805.iwasaki@jp.FreeBSD.org>
Message-ID: <20030918102054.T15072@root.org>
References: <20030914225148.2e1a21f7.aizu@navi.org> <20030916161328.Q10247@root.org>
 <20030918231149.7e57383b.aizu@navi.org> <20030919.013121.43004805.iwasaki@jp.FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
Date: Thu, 18 Sep 2003 10:29:25 -0700
X-Sequence: acpi-jp 2680
Subject: [acpi-jp 2680] Re: TOSHIBA HCI driver on ACPI.
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: nate@root.org
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+030902

On Fri, 19 Sep 2003, Mitsuru IWASAKI wrote:
> > I revised acpi_toshiba.c again. And the code size reduced to half.
>
> Cool!
> I think this driver should be kernel loadable module only driver
> for Toshiba laptop users.  Small patches and module Makefile attached.
> Here is my rough idea for this driver.
> Source file path:    sys/i386/acpi/acpi_toshiba.c
> Module compile path: sys/modules/acpi/acpi_toshiba/

I would prefer these paths:
Src:  sys/dev/acpi_toshiba
Modules:  sys/modules/acpi_toshiba
It's ok to have a driver outside of its parent bus's tree that depends on
it.  See miibus and say fxp.

It also could use a man page.

Are either of you willing to take a look at the Linux ASUS driver and
rewrite it in a similar manner?  Also, if anyone has an ASUS laptop and
would be willing to test a new driver, that would be good.
   linux/drivers/acpi/asus_acpi.c

> Adding to ports collecton (sysutils?) also would be possible.

I like your changes.  I'd rather have this imported than in a port since
it is simple and will be easy to maintain.

Thanks,
-Nate


