From owner-acpi-jp@jp.FreeBSD.org Sat Sep 20 03:52:19 2003
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) id h8JIqJa01958;
	Sat, 20 Sep 2003 03:52:19 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from hermes.home.paeps.cx (postfix@hermes.home.paeps.cx [2001:ab8:2007:10:20c:6eff:fe4b:23f])
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) with ESMTP/inet6 id h8JIqHJ01953
	for <acpi-jp@jp.FreeBSD.org>; Sat, 20 Sep 2003 03:52:18 +0900 (JST)
	(envelope-from philip@home.paeps.cx)
Received: by hermes.home.paeps.cx (Postfix, from userid 1001)
	id B53026D; Fri, 19 Sep 2003 20:52:13 +0200 (CEST)
From: Philip Paeps <philip+freebsd@paeps.cx>
To: acpi-jp@jp.FreeBSD.org
Message-ID: <20030919185213.GB635@hermes.home.paeps.cx>
Mail-Followup-To: acpi-jp@jp.FreeBSD.org
References: <20030914225148.2e1a21f7.aizu@navi.org> <20030916161328.Q10247@root.org> <20030918231149.7e57383b.aizu@navi.org> <20030919.013121.43004805.iwasaki@jp.FreeBSD.org> <20030918102054.T15072@root.org> <20030919093728.GC652@hermes.nixsys.be> <20030919110103.E22778@root.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030919110103.E22778@root.org>
X-Date-in-Rome: ante diem XIII Kalendas Octobres MMDCCLVI ab Urbe Condida
X-PGP-Fingerprint: FA74 3C27 91A6 79D5 F6D3 FC53 BF4B D0E6 049D B879
X-Message-Flag: Get a proper mailclient!  Mutt: <http://www.mutt.org/>
User-Agent: Mutt/1.5.4i
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
Date: Fri, 19 Sep 2003 20:52:13 +0200
X-Sequence: acpi-jp 2687
Subject: [acpi-jp 2687] Re: TOSHIBA HCI driver on ACPI.
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: philip+freebsd@paeps.cx
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+030902

On 2003-09-19 11:04:29 (-0700), Nate Lawson <nate@root.org> wrote:
> On Fri, 19 Sep 2003, Philip Paeps wrote:
> > > Are either of you willing to take a look at the Linux ASUS driver and
> > > rewrite it in a similar manner?  Also, if anyone has an ASUS laptop and
> > > would be willing to test a new driver, that would be good.
> > > linux/drivers/acpi/asus_acpi.c
> >
> > I'm still working on this.  It's been on the backburner for a bit, sorry
> > about that.  Attached is what's currently working pretty well on my laptop
> > (L3H) and a friend's L3D.
> 
> Thanks, I had forgotten you were working on this.

I was rather quiet for a while :-)

> One thing you should look into doing is removing read/write_int.  See
> acpi_EvaluateInteger() instead.  

I did actually use that initially to get/set the led bits.  But then I needed
a buffer for the brightness and other stuff.  I could modify the function to
deal with buffers though, unless there's any reason not to?

> Also, there are some style bugs (long lines > 80 columns).  

Whoops, time to stick tw=78 in my vimrc again.

> Once the driver is more finished, I'd be happy to import it.

Fantastic, thanks!  I'll get hacking on it :-)

 - Philip

-- 
Philip Paeps                                          Please don't CC me, I am
                                                       subscribed to the list.

  A pat on the back is only a few inches from a kick
  in the pants.
