From owner-acpi-jp@jp.FreeBSD.org Tue Sep 23 00:03:41 2003
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) id h8MF3fN96416;
	Tue, 23 Sep 2003 00:03:41 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from rootlabs.com (root.org [67.118.192.226])
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) with SMTP/inet id h8MF3cJ96411
	for <acpi-jp@jp.freebsd.org>; Tue, 23 Sep 2003 00:03:41 +0900 (JST)
	(envelope-from nate@rootlabs.com)
Received: (qmail 40117 invoked by uid 1000); 22 Sep 2003 15:03:33 -0000
From: Nate Lawson <nate@root.org>
To: Andi Kleen <ak@suse.de>
cc: acpi-jp@jp.FreeBSD.org, acpi-devel@lists.sourceforge.net
In-Reply-To: <20030922145315.GC13165@wotan.suse.de>
Message-ID: <20030922080137.G40076@root.org>
References: <20030918221109.L16619@root.org> <20030922145315.GC13165@wotan.suse.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
Date: Mon, 22 Sep 2003 08:03:33 -0700
X-Sequence: acpi-jp 2689
Subject: [acpi-jp 2689] Re: [ACPI] [PATCH] invalid resource lists and extra checking
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: nate@root.org
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+030902

On Mon, 22 Sep 2003, Andi Kleen wrote:
> > --- rsaddr.c	13 Jul 2003 22:43:31 -0000	1.1.1.11
> > +++ rsaddr.c	19 Sep 2003 04:59:50 -0000
> > @@ -168,6 +168,10 @@
> >      Buffer += 1;
> >      ACPI_MOVE_16_TO_16 (&Temp16, Buffer);
> >
> > +    /* Check for the minimum length. */
> > +    if (Temp16 < 13)
> > +        return_ACPI_STATUS (AE_AML_INVALID_RESOURCE_TYPE);
>
> For which acpica version is this exactly? I tried to apply it to a Linux
> tree which has nearly the latest, but it rejected on every hunk.
> The file is also repetive enough that hand applying looks a bit risky.
>
> Can you perhaps post a patch against the latest ACPICA version?

This was against 0619.  Things can't have diverged THAT much since the
only public release after this was 0714 and the linux pushes have been
mostly in the linux-specific code (i.e. PIC).  I have a feeling you didn't
run the patch through the LiNuXuLaTor de-caps tool and that's why it
rejected.  Apply it against a stock acpica unix dist and then de-caps it.

-Nate
