From owner-acpi-jp@jp.FreeBSD.org Tue Mar  9 14:45:28 2004
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) id i295jSS80011;
	Tue, 9 Mar 2004 14:45:28 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from root.org (root.org [67.118.192.226])
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) with SMTP/inet id i295jR780004
	for <acpi-jp@jp.FreeBSD.org>; Tue, 9 Mar 2004 14:45:27 +0900 (JST)
	(envelope-from nate@root.org)
Received: (qmail 50947 invoked by uid 1000); 9 Mar 2004 05:45:22 -0000
From: Nate Lawson <nate@root.org>
To: Lukas Ertl <l.ertl@univie.ac.at>
cc: acpi-jp@jp.FreeBSD.org
In-Reply-To: <20040308021112.P688@korben.in.tern>
Message-ID: <20040308214455.G50782@root.org>
References: <20040308021112.P688@korben.in.tern>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
Date: Mon, 8 Mar 2004 21:45:22 -0800
X-Sequence: acpi-jp 3104
Subject: [acpi-jp 3104] Re: acpi_video driver not working
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: nate@root.org
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+040307

On Mon, 8 Mar 2004, Lukas Ertl wrote:
> I tried the new acpi_video driver on my ThinkPad, but unfortunately the
> provided sysctls don't work:
>
> # sysctl hw.acpi.video
> hw.acpi.video.lcd0.active: 1
> hw.acpi.video.crt0.active: 0
> hw.acpi.video.tv0.active: 0
> hw.acpi.video.out0.active: 0
>
> # sysctl hw.acpi.video.lcd0.active=0
> hw.acpi.video.lcd0.active: 1 -> 1
>
> I think I have found out why: DSS_COMMIT is defined as (UINT32)1 << 31,
> which overflows the (signed int) 'number' param of acpi_SetInteger(), and
> subsequently the ACPI_OBJECT Integer.Value member.
>
> Any ideas on how to get around this?

I've committed a fix, let me know if it works for you.  The overarching
problem is that acpi_video needs cleanup.

-Nate
